Stripe: Apple Pay & Google Pay integration using Payment Request Button

Stuart

Hi,
I am trying to add Apple Pay & Google Pay with Stripe Payment. I have completed domain verification by downloading domain association file according to stripe documentation (https://stripe.com/docs/stripe-js/elements/payment-request-button). Now, stuck after adding payment request button element in /themes/tastyigniter-orange/_partials/payregister/stripe.php

Payment request button element:
<div id=“payment-request-button”>
<!– A Stripe Element will be inserted here. –>
</div>

Nothing appears when I tried on my iPhone and Mac. I tried stripe demo: https://stripe-payments-demo.appspot.com/ which appears with Apple Pay button on top.

Not sure what to do next, please help me out here. It will be a great option to have Apple Pay & Google Pay on board, also it is very secure and users will love it.
Also, it will be a good idea to have Idempotent Requests enabled in Stripe which will reduce duplicate payment process (Sometime duplicate or double payment gets through the system due to slow connection or some other reason). Just adding Idempotency-Key: can help resolving this issue quite easily.

ryanmitchell

Stuart for the payment request button, you would need to add the JS required to extensions/igniter/payregister/assets/process.stripe.js. It would be great if you got this working well to open up a pull request so the code could be used by others.

Same goes for idempotent requests - this would be a great addition and a relatively simple PR - it should be a case of adding the array key here https://github.com/tastyigniter/ti-ext-payregister/blob/master/payments/Stripe.php with a uniqid() or some other unique string.

If you get stuck I’m here to help so just let me know.

andrew

Hi Stuart, just going out on a limb here as I’m not a developper. Could it be something related to the radiotoggle form field type? Just guessing that the form might have to be modified also. https://github.com/tastyigniter/ti-ext-payregister/tree/master/payments

andrew

Also, are you getting customer name/order information relayed through to your stripe admin panel? I just realized stripe.php has had some updates in the past month, I’ll update the file tomorrow and see if that helps.

andrew

was doing a demo today, and got a double spend on stripe.. luckily the resto didn’t realize, but potential to be a big problem if it happens on a live version. I was using a PC I don’t usually use, and if the mouse is over a button it clicks automatically, in this case twice. Any luck with the idempotent requests?

andrew

https://stripe.com/docs/api/idempotent_requests

ryanmitchell

@andrew I left this for @Stuart or others to contribute to working on as its an easy way to get involved in the project and give something back.

ryanmitchell

@andrew the idempotency fix has been added to the pay-register extension

@Stuart can you let me know if you plan to work on the payment request button?

andrew

Thanks ryan! I wish I could help but I don’t have developper skills. I appreciate everything you guys are doing.

andrew

Still getting double spend problem
In stripe.php I think the problem with double spends come from

   return [
        'stripe_payment_method' => '',
        'idempotency_key' => uniqid(),
    ];
}

I’m not sure as i’m not a dev, but I don’t think it’s a complete request to generate a v4 UUID to prevent the double spend. Have you guys been able to test double spend after update? (by clicking really fast on confirm when in final phase of checkout)
https://www.php.net/manual/en/function.uniqid.php
https://stackoverflow.com/questions/2040240/php-function-to-generate-v4-uuid

ryanmitchell

The idempotencyKey just has to be a unique value in a 24 hour period, they mention UUIDv4 as its guaranteed unique always, but its not a requirement and uniqid() is more than sufficient for this.

If you’re still seeing duplicate payments then its something that idempotency wont fix and the issue is elsewhere. If you’re able to tie it down any further let me know and I’ll look into it.