Wrong Pick up times. All set to 15:00.

sampoyigi

Nicely spot @supply@dashihui.uk

I've added the fix to git

https://github.com/tastyigniter/TastyIgniter/commit/d9bec59b2c3de2023f4148361528bd09f07a55d1

Manctech

This is happening to me but some of the code above seems to have been replaced with an emoji Icon. Please can you repost and tick the box Disable smilies

Just testing to see if I have found the missing piece. $order_time = (strtotime($order_info['order_time']) < $current_time) ? date('Y-m-d H:i:s', $current_time) : $order_info['order_time'];

Yep for anyone else needing the above code it is an :s where the emoji face is. $order_time = (strtotime($order_info['order_time']) < $current_time) ? date('Y-m-d H:i:s', $current_time) : $order_info['order_time'];

Sorry : s without the space. : s

zeta

Today 7/18/2017,

Most orders were set to a pickup time of 15:00 even though orders were set to be picked up as soon as possible. During checkout, the time looks correct and matches what the user has selected. But once the payment has been processed, on the checkout success page the time is set to 3:00PM.

This happens even when the orders are placed around 6:00PM (past the 15:00 time).

Has anybody had a similar problem? If so, what was the fix?

Update: After a few days, I looked back at these orders and it seems like the year on the dates is all messed up

zeta

Thanks supply@dashihui.uk ! I never thought I'd get a solution for that problem

supply@dashihui.uk

Hi Universe12, in the method orderTimeRange() in Location.php, find code similar like below, comment out the original line ( I have done as exameple below ), replace with a new line I added immediately after that one. This is actually the order_time written into the database table for ti_orders with same column name, so it will show in the checkout, in the email, and in the database.

if (strtotime($time) >= ($this->current_time + ($time_interval * 60))) { if ($hour['working_status'] === 'open' AND $count === 1) { // $order_times['asap'] = $time; $order_times['asap'] = date('d-m-Y H:i', $this->current_time + ($time_interval * 60));

supply@dashihui.uk

Seems question is answered by myself - it maybe a imperfection in code: Orders_model.php , method: addOrder($order_info, $cart_contents ) , some system interpret the now() function to epoch time instead of human readable timestamp, so please replace following line with a new line: old line:

[php] // $order_time = (strtotime($order_info['order_time']) < strtotime($current_time)) ? $current_time : $order_info['order_time']; [/php]

new line: [php] $order_time = (strtotime($order_info['order_time']) < $current_time) ? date('Y-m-d H:i:s', $current_time) : $order_info['order_time'];[/php]

this problem took me a good few hours to debug, hope it helps. BBY

supply@dashihui.uk

sure, I paste again and disable smilies as below:

in Orders_model.php , method name: addOrder

new line: $order_time = (strtotime($order_info['order_time']) < $current_time) ? date('Y-m-d H:i:s', $current_time) : $order_info['order_time']; old line: ( I've commented it out already ) // $order_time = (strtotime($order_info['order_time']) < strtotime($current_time)) ? $current_time : $order_info['order_time'];

supply@dashihui.uk

Many thanks Sam !

supply@dashihui.uk

I have same issue, all delivery hours were set to 15:

supply@dashihui.uk

Hello Nettower, thanks for your message. I think that is a separate issue. From the reading of code, all available time slot for next delivery time is put into an array. I am not sure why the initial coding is like that. I am not to comment if that is suit for purpose. But, I used a temporarily work around, by changing the the delivery time from its next value from array, to current time + delivery interval, e.g. if current time is 17:07, and delivery time is 40 minutes, it will show 17:47 instead the next value from its array. To get this work aroud done, you need to modify code in the orderTimeRange() method in Location.php, change $order_times['asap'] value from $time to date('d-m-Y H:i', $this->current_time + ($time_interval * 60));

I would not suggest to have author to modify the official code, because this is just a preference, not a bug. the best way is for code to provide a method to allow choosing fixed time slot like current code does, or to just use the current time + delivery interval, which I described as above. Regards BBY

Universe12

supply@dashihui.uk wrote Hello Nettower, thanks for your message. I think that is a separate issue. From the reading of code, all available time slot for next delivery time is put into an array. I am not sure why the initial coding is like that. I am not to comment if that is suit for purpose. But, I used a temporarily work around, by changing the the delivery time from its next value from array, to current time + delivery interval, e.g. if current time is 17:07, and delivery time is 40 minutes, it will show 17:47 instead the next value from its array. To get this work aroud done, you need to modify code in the orderTimeRange() method in Location.php, change $order_times['asap'] value from $time to date('d-m-Y H:i', $this->current_time + ($time_interval * 60)); I would not suggest to have author to modify the official code, because this is just a preference, not a bug. the best way is for code to provide a method to allow choosing fixed time slot like current code does, or to just use the current time + delivery interval, which I described as above. Regards BBY

Thank you very much fro your help! I just need the code a little bit more clear please! I'm on orderTimeRange() of the file Location.php, but it's not really clear for me wich lines I need to change to make it work! Could you please say for example, line 404 ......................... to be replaced with............................

Thank you very much!!!

Is this fix going to fix even the delivery as well?

Universe12

Thank you Very much! It's fixed now!!!

nettower

supply@dashihui.uk wrote Seems question is answered by myself - it maybe a imperfection in code: Orders_model.php , method: addOrder($order_info, $cart_contents ) , some system interpret the now() function to epoch time instead of human readable timestamp, so please replace following line with a new line: old line: [php] // $order_time = (strtotime($order_info['order_time']) < strtotime($current_time)) ? $current_time : $order_info['order_time']; [/php] new line: [php] $order_time = (strtotime($order_info['order_time']) < $current_time) ? date('Y-m-d H:i:s', $current_time) : $order_info['order_time'];[/php] this problem took me a good few hours to debug, hope it helps. BBY Hey BBY, do you know how to change delivery time/pick time be calculated from the moment (from the minute) the order is placed, because at this moment calculating start from next exact time. It means if I set delivery time 60min and pick up 30 min, and customer place the order at 15:51. Module calculate delivery time clock 16:00 and pick up time 16:30.

nettower

supply@dashihui.uk wrote Hello Nettower, thanks for your message. I think that is a separate issue. From the reading of code, all available time slot for next delivery time is put into an array. I am not sure why the initial coding is like that. I am not to comment if that is suit for purpose. But, I used a temporarily work around, by changing the the delivery time from its next value from array, to current time + delivery interval, e.g. if current time is 17:07, and delivery time is 40 minutes, it will show 17:47 instead the next value from its array. To get this work aroud done, you need to modify code in the orderTimeRange() method in Location.php, change $order_times['asap'] value from $time to date('d-m-Y H:i', $this->current_time + ($time_interval * 60)); I would not suggest to have author to modify the official code, because this is just a preference, not a bug. the best way is for code to provide a method to allow choosing fixed time slot like current code does, or to just use the current time + delivery interval, which I described as above. Regards BBY Many thanks once again! :)