V2.1.1: Added custom column to _customer db table for email validation

h4x0rjdag

I created the new column "validated" to my _customers table as tinyint(1)
in main/controllers/account/register.php inside the function private function _addCustomer() i added a new line as follows...

private function _addCustomer() {
		if ($this->validateForm() === TRUE) {
            $this->load->model('Customers_model');													// load the customers model
            $this->load->model('Customer_groups_model');

 			$add = array();

 			// if successful CREATE an array with the following $_POST data values
			$add['first_name'] 				= $this->input->post('first_name');
			$add['last_name'] 				= $this->input->post('last_name');
			$add['email'] 					= $this->input->post('email');
			$add['password'] 				= $this->input->post('password');
			$add['telephone'] 				= $this->input->post('telephone');
			$add['security_question_id']	= $this->input->post('security_question');
			$add['security_answer'] 		= $this->input->post('security_answer');
			$add['newsletter'] 				= $this->input->post('newsletter');
			$add['terms_condition'] 		= $this->input->post('terms_condition');
			$add['customer_group_id'] 		= $this->config->item('customer_group_id');
			$add['date_added'] 				= mdate('%Y-%m-%d', time());
			_$add['validated'] 				= '0'; //the table _customers has this column added as tinyint(1)_

			$result = $this->Customer_groups_model->getCustomerGroup($this->config->item('customer_group_id'));
			if ($result['approval'] === '1') {
				$add['status'] = '0';
			} else {
				$add['status'] = '1';
			}

Registration works fine but the column has null instead of the 0. Did I miss something or is there anywhere else I would need to add code for this to work?

sampoyigi

h4x0rjdag I just saw the error, funny i missed it earlier.

You are using validated as the column name when writing the value.

h4x0rjdag _$add['validated'] = '0'; //the table customers has this column added as tinyint(1)

But then you have activated here which should be validated when reading the value from the database

h4x0rjdag $this->CI->db->where('activated', '1');

Make sense?

h4x0rjdag

also the line is actually...
$add['validated'] = '0'; //the table _customers has this column added as tinyint(1)
i was going to italicize it for easier identification but i guess it doesn't work inside of a code snippet.

sampoyigi

You'll need to set the value for the validated column within the Customers_model::saveCustomer function.

Something like:

if (isset($save['validated'])) {
	$this->db->set('validated', $save['validated']);
}

h4x0rjdag

sampoyigi thank you! that worked but led me to my next speed-bump.
i'm trying to make sure the login fails if a customer's "validated" value is 0.

i added line 84 in /system/tastyigniter/libraries/Customer.php

83:		$this->CI->db->where('status', '1');
84:		$this->CI->db->where('activated', '1'); // the added line

without the added line it works fine. once added i receive the following error

ERROR - 2019-01-07 04:37:05 --> Query error: Unknown column 'activated' in 'where clause' - Invalid query: SELECT *
FROM `ti_customers`
WHERE `email` = 'hfdsfgdfgdsdg@gmail.com'
AND password = SHA1(CONCAT(salt, SHA1(CONCAT(salt, SHA1("gfdsgsgfds")))))
AND `status` = '1'
AND `activated` = '1'
ERROR - 2019-01-07 04:37:05 --> Severity: error --> Exception: Call to a member function num_rows() on boolean /system/tastyigniter/libraries/Customer.php 87

thanks again in advance of any help 🙂

narendra

sampoyigi Best approach to do it like....

$validated = ($save['validated']) ? $save['validated'] : 0 ;
$this->db->set('validated', $validated);

This will help to do execution fast rather to use if else and shorter code is at least potentially more readable since it focuses on the relevant part rather than on incidental effects. 😉

sampoyigi

h4x0rjdag The added line should work. Is there a chance the column doesn't exist in the database?

h4x0rjdag

sampoyigi it's there. i can read/write the value if i do all the sql with my own code.

h4x0rjdag

ty. jesus i spent a while looking and my brain was just autocompleting my thoughts. so sorry !