Open hours showing incorrectly.

pugy365

The opening times are showing as closing time to closing time. For example We are open 6AM to 11pm for orders, but instead of 6AM to 11PM it says on our store page 11:00PM to 11:00PM. Is this just a bug?

mlattke

pugy365 Check the times format. Should be hh:mm

pugy365

Let me clarify, it’s not showing the opening time, just the closing time twice. It’s in the (he:mm) format.

sampoyigi

pugy365 Are you using the flexible hour type? Can you share a screenshot of your opening hours?

pugy365

I’m just using regular hours, see below links.

https://www.dropbox.com/s/haofyg06x8z4bty/9952A300-279C-466B-BE38-E26DF04B5E70.jpeg?dl=0

https://www.dropbox.com/s/5w3yrrk4nihviyx/C5AF6795-596F-4C28-B315-65CE1006836A.jpeg?dl=0

sampoyigi

pugy365 I’ve tried both locally and on the demo site and still can’t reproduce the error.

fad

Hello!
I have exactly the same problem:
https://nextcloud.saratovcafe.ru/index.php/s/dwCZSWaP6FeneRg

In version 3.0.4-beta19 there was no such problem.
I tried to figure it out and realized that there might be a problem in the getOpenTime() function.

sampoyigi

fad Can you try the fix here by @olieydt, could be related?

pugy365

@sampoyigi Where would I apply the code that is in that fix?

EDIT:

That fixed it! Found the file in WEBROOT/vendor/tastyigniter/flame/src/Location if anyone else is looking.

Thanks for all your help @sampoyigi

eko

pugy365 I applied the fix but it does give a timeout error. The browser just keeps spinning. Not sure why the code is causing this. Help appreciated!

fad

@sampoyigi Exactly what is needed!
thanks Mr. Sam

sampoyigi

fad Great stuff! thanks for letting me know. PR will be merged into the next update 🙂

fedex

eko
Do you have pickup or delivery with no time setted?

eko

We do not do delivery, let me set a time,

eko

Still same problem, is something with the code. At the moment with the current code it will display correctly until the opening time then it switches both times to the same, for example opening 10:00 and closing 15:00 these times are displayed correctly outside these times but as soon as opening time changes to e.g. 10:30 then the closing time also shows 10:30, thus 10:30-10:30. I thought the fix would solve this but now just times the site out.

yxd117

eko try the fix here as suggested. It seems that the merged code is not updated when we do the setup.

eko

yxd117 That is the fix I applied and that causes the problem.

eko

yxd117 The problem that the fix doesn’t work as at beginning of post

eko

I noticed that the problem with the unfixed code is actually that once the time set become active the start time becomes the closing time. In our case once we open it shoots from 9am start time straight to 3pm closing (Government regulations do not allow takeaways after that). If anything that means the start just changes to the closing time. In the back it operates properly in that the order taking gets closed after end-time of takeway period and only re-opens at the start time. I wonder why the start time on display needs to change though from the stored variable. I am not a programmer but wonder how the onscreen display of start and closing times can not just be taken from the variables we entered in restaurant admin as the function itself to open and close ordering works well.

eko

In addition to above. When changing times when first open and all functioning well and when passed the opening time try to extend it by putting a new setting in the admin/restaurant part it no longer shows the + sign and one can not add anything to the order. I even reset everthing nd make it 24/7. Still no plus signs. Please help!!