Translation approval request

breaksecurity

@sampoyigi Can you approve all the Italian translation I have done? Thank you

sampoyigi

breaksecurity Thank you for your contributions! I’ve approved all translations! 👍️

breaksecurity

It is a pleasure. I will test the translation “feeling” and update in the next days 😉

breaksecurity

@sampoyigi Hi! I noticed that many translations that I modified has not been approved like: “Delivery Pre-order Days In Advance”

Could you approve all of my suggested translation please? Thank you very much!

breaksecurity

@sampoyigi just to ping you on this 😀

sampoyigi

breaksecurity Sorry, I didn’t see your modified translations earlier.

When translating your suggestions back to English it doesn’t match the original English string its translating. See the example below for Set the number of days a customer can order for pick-up in advance.

Here’s the one suggested by @binco

breaksecurity

sampoyigi Yes I know but they share the same meaning and they sounds much better in Italian. A translation made word by word sounds artificial and not natural at all. Fell free to decide but they will improve the general feeling for both customer and workers.

breaksecurity

breaksecurity Plus we found a lot of errors too

sampoyigi

breaksecurity I’m not a native speaker so I can’t judge on how it sounds, the best I can do is compare it to English or approve based on suggestions/ratings.

The English translations have errors too and could be improved but until then I feel the translated string should match their base version to avoid confusion.

breaksecurity

@sampoyigi That’s reasonable. One more question, when I edit the lang strings from the admin UI where get those stored?

sampoyigi

breaksecurity It gets stored in language_translations db table.

breaksecurity

sampoyigi Is there a simple way to export those in a folder? to copy them across several sites? Also this will avoid a lot of DB connections

sampoyigi

breaksecurity Its already copied to a file through caching. A DB connection only happens when retrieving the translation for the first time or when the string changes.

breaksecurity

sampoyigi Thanks Can you point me to this file so I can copy translation to a folder without dealing with db import export?

sampoyigi

breaksecurity That will be tricky as the file is dynamically generated. If you want to copy the translations over to a different site, then a DB import/export is your best option. If that won’t work, you can write a small script to create local lang files from the DB translations.

breaksecurity

sampoyigi Can I open a issue for a feature request to save on the file the translation and empty DB. Also download translation and Install those maybe

breaksecurity

@sampoyigi ping

ryanmitchell

Yes open an issue so it can be discussed